Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle IOBuffer signatures on 0.6 and 0.7 #248

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

iamed2
Copy link
Contributor

@iamed2 iamed2 commented Feb 24, 2018

Tests should pass on 0.6 now.

@TotalVerb
Copy link
Collaborator

see also JuliaLang/Compat.jl#501

@samoconnor
Copy link

It would be great if you could merge this and tag!
0.6 code is breaking in the wild: JuliaCloud/AWSCore.jl#29

@TotalVerb
Copy link
Collaborator

We can merge this and replace with the Compat change later.

@TotalVerb TotalVerb merged commit 659c5eb into JuliaIO:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants