Skip to content

Commit

Permalink
change close(::SerialPort) to return nothing
Browse files Browse the repository at this point in the history
That what other close(::IO) methods in Base do. It looks quite odd in the
REPL to get the entire closed SerialPort object thrown back at you.
  • Loading branch information
mgkuhn committed Aug 17, 2020
1 parent c1fe628 commit 21c0a04
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/high-level-api.jl
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ function close(sp::SerialPort)
sp_close(sp.ref)
sp.is_open = false
end
return sp
return
end

# fixes https://github.com/JuliaIO/LibSerialPort.jl/issues/53
Expand Down

0 comments on commit 21c0a04

Please sign in to comment.