Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update high-level-api.jl - Don't merge #25

Closed
wants to merge 1 commit into from

Conversation

s-celles
Copy link
Contributor

Closes #23
Closes #24

@s-celles
Copy link
Contributor Author

s-celles commented Aug 30, 2018

However

I wonder if it won't be more consistant to have readuntil:

  • returning a String if delim is a String
  • returning a Vector{Char} if delim is a Vector{Char}
  • returning a Vector{UInt8} if delim is a Vector{UInt8}

what is your opinion @andrewadare ?

@s-celles
Copy link
Contributor Author

s-celles commented Aug 30, 2018

Something like

out = typeof(delim)()

or

out = Vector{T}()

and

push!(out, c)

instead of

write(out, c)

and

return out

instead of

return String(take!(out))

@s-celles s-celles changed the title Update high-level-api.jl [WIP] Update high-level-api.jl - Don't merge Aug 30, 2018
@tknopp tknopp mentioned this pull request Sep 8, 2018
@samuelpowell
Copy link
Collaborator

I assume this is now stale and can be closed, but feel free to reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants