Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing timeout implementation from #61 and fixed #72 (missing flow-control setting in tests) #74

Merged
merged 7 commits into from
Nov 11, 2020

Commits on Aug 17, 2020

  1. fix test_low_level_api() by actually disabling flow control

    This test routine claimed in a comment to disable flow control. It
    actually requires the serial port to be transparent for all 256 byte
    values, which in turn requires deactivation of software flow control,
    because otherwise the byte-transparency tests fail for bytes 0x11
    (Ctrl-Q, XON) and 0x13 (Ctrl-S, XOFF) on systems such as Ubuntu Linux
    where software flow control is active by default.
    mgkuhn committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    ef40f3b View commit details
    Browse the repository at this point in the history
  2. completed read/write timeout implementation in high-level API

    Added new functions to set and clear cumulative timeouts for blocking
    read and write functions, a new `Timeout` exception that will be
    thrown, and time-tracking code in calls to the blocking read/write
    functions. This way, users can now set overall timeouts on other IO
    functions, such as `readuntil`, that make multiple calls to our
    blocking functions.
    mgkuhn committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c1fe628 View commit details
    Browse the repository at this point in the history
  3. change close(::SerialPort) to return nothing

    That what other close(::IO) methods in Base do. It looks quite odd in the
    REPL to get the entire closed SerialPort object thrown back at you.
    mgkuhn committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    21c0a04 View commit details
    Browse the repository at this point in the history
  4. build HTML documentation using Documenter.jl

    also polished some docstrings and fixed a parameter name inconsistency
    mgkuhn committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    75d6ddc View commit details
    Browse the repository at this point in the history
  5. split low-level API into separate module (JuliaIO#68)

    The low-level API wrappers now sit in a submodule LibSerialPort.Lib.
    
    The high-level API currently still re-exports a few symbols from that
    low-level API module, to preserve backwards compatibility.
    
    This is due to
    
    * my previously started attempt to merge the low and high-level
      APIs for the three functions sp_flush, sp_drain, and sp_output_waiting
    
    * the fact that several high-level APIs currently still refer to
      enum types and constants defined by the low-level API
    
    We may want to phase out either or both in future, for a cleaner
    separation, and a more Julian high-level API.
    mgkuhn committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    61d1a59 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. documentation typo fixed

    mgkuhn authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    cba0fce View commit details
    Browse the repository at this point in the history
  2. allow arm64 to fail

    Arm64 builds have long filed, therefore let's allow them to fail in Travis until that problem is fixed, such that PR authors for other issues do not get build errors that they are not responsible for.
    mgkuhn authored Nov 11, 2020
    Configuration menu
    Copy the full SHA
    4803294 View commit details
    Browse the repository at this point in the history