Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro hygiene: don't assume StructIO is in scope in io macro #29

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Aug 9, 2024

Should fix #24.

@yuyichao
Copy link

yuyichao commented Aug 9, 2024

This should work?

julia> module A
       function f end
       macro m(T, v)
           :($A.f(::$(esc(T))) = $(esc(v)))
       end
       end
Main.A

julia> A.@m Int 2

julia> A.f(1)
2

@stevengj
Copy link
Member Author

stevengj commented Aug 9, 2024

Look like the nightly failure is an unrelated change to the docsystem (#30).

Update pushed after rebase with workaround for JuliaLang/julia#55438

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (1b79251) to head (0ef98bd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files           1        1           
  Lines         128      128           
=======================================
  Hits          121      121           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj stevengj merged commit 7651ffa into master Aug 9, 2024
7 checks passed
@stevengj stevengj deleted the stevengj-patch-1 branch August 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@io depends on StructIO being imported
2 participants