Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for bit_depth #314

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

IanButterworth
Copy link
Member

@galenlynch this appears to be a typo. Can you confirm?

Evidently our tests aren't covering this branch.

Fixes #313

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #314 (e42c547) into master (7709189) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   81.45%   81.45%           
=======================================
  Files          17       17           
  Lines        1181     1181           
=======================================
  Hits          962      962           
  Misses        219      219           
Impacted Files Coverage Δ
src/avio.jl 81.34% <0.00%> (ø)
src/frame_graph.jl 99.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7709189...e42c547. Read the comment docs.

@galenlynch
Copy link
Collaborator

Whoops my bad. That is definitely a typo, but the correct value is bit_depth, not padded_bits_per_pixel. I'll make a PR against your branch.

@IanButterworth IanButterworth changed the title Fix typo for padded_bits_per_pixel Fix typo for bit_depth Apr 7, 2021
@IanButterworth
Copy link
Member Author

@galenlynch this slipped through. Do you recall if it's still correct? I assume so, but confirmation would be appreciated

@IanButterworth IanButterworth merged commit baa8d70 into master Mar 7, 2022
@IanButterworth IanButterworth deleted the IB/fix_padded_bits_per_pixel branch March 7, 2022 19:33
@galenlynch
Copy link
Collaborator

Hey sorry I've been AWOL. Will check it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefVarError bits_per_pixel when transforming to gray during decoding
2 participants