Avoid exporting garbage from libffmpeg
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autoexport mechanism in `libffmpeg` is exporting literally _everything_, including over one thousand of totally useless names, like `Symbol("##meta#58")` which happens to be already defined in `VideoIO`, causing a clash.
IanButterworth
approved these changes
Feb 2, 2023
Codecov ReportBase: 79.38% // Head: 79.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 79.38% 79.38%
=======================================
Files 10 10
Lines 1276 1276
=======================================
Hits 1013 1013
Misses 263 263 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoexport mechanism in
libffmpegis exporting literally everything, including over one thousand of totally useless names, likeSymbol("##meta#58")which happens to be already defined inVideoIO, causing a clash.