Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parker weighting for short scans #40

Merged
merged 9 commits into from
Dec 22, 2022
Merged

Add Parker weighting for short scans #40

merged 9 commits into from
Dec 22, 2022

Conversation

JeffFessler
Copy link
Member

Hopefully will address #39.
Also using Type{<:Number} instead of DataType because somewhere the manual recommended it.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 99.61% // Head: 99.62% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1688f4c) compared to base (daecffe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   99.61%   99.62%   +0.01%     
==========================================
  Files          31       31              
  Lines         774      797      +23     
==========================================
+ Hits          771      794      +23     
  Misses          3        3              
Impacted Files Coverage Δ
src/fbp/window.jl 100.00% <ø> (ø)
src/fbp2/back-fan.jl 97.95% <ø> (ø)
src/fbp2/back-par.jl 97.36% <ø> (ø)
src/fbp3/cbct-back.jl 98.36% <ø> (ø)
src/geom/ct-geom.jl 100.00% <ø> (ø)
src/geom/sino-geom.jl 100.00% <ø> (ø)
src/geom/util.jl 100.00% <ø> (ø)
src/fbp2/fbp.jl 100.00% <100.00%> (ø)
src/fbp2/parker.jl 100.00% <100.00%> (ø)
src/fbp2/plan2.jl 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tknopp tknopp assigned tknopp and unassigned tknopp Dec 22, 2022
@tknopp
Copy link
Member

tknopp commented Dec 22, 2022

Well, what should I say: It just works!

Thanks for the quick implementation!

@JeffFessler JeffFessler merged commit 0de04f2 into main Dec 22, 2022
@JeffFessler JeffFessler deleted the parker branch December 22, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants