-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Interval{Float64}^x #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 92.31% 92.19% -0.13%
==========================================
Files 21 21
Lines 924 999 +75
==========================================
+ Hits 853 921 +68
- Misses 71 78 +7
Continue to review full report at Codecov.
|
The problem is that the rounded versions of ^ still use BigFloat internally. There is some kind of power available in CRlibm that I didn't wrap, but it is known that correctly rounding the power function is very difficult. That is why the only solution I see is not to demand tight correct rounding. |
This PR replaces the version that uses At the moment I am playing with ``^(a::Interval{Float64}, n::Float64)` to see how far can I get. |
This is ready for review; test pass locally! |
I was referring to these lines, where |
You are totally right; I forgot the changes in |
Closing this, to think this over... |
This PR uses only
Float64
arithmetic to implement a method for^(a::Interval{Float}, n::Integer)
, i.e., avoids usingbig53
.