1.0-dev: fix stack overflow error (#513, #538) #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## 1.0-dev #562 +/- ##
===========================================
- Coverage 84.79% 84.78% -0.01%
===========================================
Files 33 33
Lines 1828 1827 -1
===========================================
- Hits 1550 1549 -1
Misses 278 278
☔ View full report in Codecov by Sentry. |
|
LGTM thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just defines methods for
rad2deg,deg2radandsincospito avoid the default fallback methods from Base which resulted inStackOverflowError.This fixes #513 and #538.
It was noted in #513 (comment) that one can define a better algorithm for
sincospi. I did not do this here, I simply definedsincospi(x) = (sinpi(x), cospi(x))for now.