Add support for OpaqueClosure
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also tightens up our call replacements and makes it quite a bit more strict regarding unresolved function pointers.
topolarity
added
bug
topolarity
commented
Jan 30, 2024
| # by AllocCheck.jl, but is instead (conservatively) marked as a DynamicDisaptch. | ||
| # | ||
| # We get thrown off by the `jl_load_and_lookup` machinery here. | ||
| @test_broken all(x isa AllocationSite && x.type == Memory{UInt8} # uses jl_string_to_genericmemory |
There was a problem hiding this comment.
I relaxed this test and marked the original as broken
We need to expand our resolution here to walk through the PhiNode in the LLVM IR and notice the ccall / jl_load_and_lookup machinery.
topolarity
force-pushed
the
ct/opaque-closure
branch
from
978581a to
65ada8c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also tightens up our call replacements and makes it quite a bit more strict regarding unresolved function pointers.