Skip to content

Commit

Permalink
Drop compat code for isnumeric from #543
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 4, 2019
1 parent 683bd1a commit 0d468db
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,6 @@ Currently, the `@compat` macro supports the following syntaxes:

* `cfunction` is now `@cfunction` ([#26486]).

* `Unicode.isnumeric` is now available as `isnumeric` ([#25479]).

* `vecnorm` and `vecdot` are now `Compat.norm` and `Compat.dot`, respectively, while the
old `norm(A::AbstractMatrix, p=2)` is now `Compat.opnorm` ([#27401]). `import Compat: ⋅`
to get `Compat.dot` as the binary operator ``.
Expand Down
6 changes: 0 additions & 6 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ end

include("compatmacro.jl")

# 0.7.0-DEV.3393
@static if VERSION < v"0.7.0-DEV.3393"
import .Unicode.isnumeric
export isnumeric
end

# 0.7.0-DEV.2951
@static if !isdefined(Base, :AbstractDict)
const AbstractDict = Associative
Expand Down
4 changes: 4 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -565,3 +565,7 @@ end
# 0.7.0-DEV.1930
@test textwidth("A") == 1
@test textwidth('A') == 1

# 0.7.0-DEV.3393
@test !isnumeric('a')
@test isnumeric('1')
4 changes: 0 additions & 4 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ let A = [1]
@test x == 1
end

# 0.7.0-DEV.3393
@test !isnumeric('a')
@test isnumeric('1')

# 0.7.0-DEV.2951
@test AbstractDict === (isdefined(Base, :AbstractDict) ? Base.AbstractDict : Base.Associative)

Expand Down

0 comments on commit 0d468db

Please sign in to comment.