Skip to content

Commit

Permalink
Mark Compat.REPL from #469 for deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 4, 2019
1 parent 3ed2409 commit 0e88da2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 17 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ Currently, the `@compat` macro supports the following syntaxes:
* `using Compat.Unicode` is provided on versions older than 0.7, where this library is not
yet a part of the standard library. ([#25021])

* `using Compat.REPL` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25544]).

* `using Compat.Serialization` is provided on versions older than 0.7, where this library is
not yet part of the standard library ([#25628]).

Expand Down
7 changes: 1 addition & 6 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,11 @@ import LinearAlgebra
import SparseArrays
import Random
import Markdown
import REPL


include("compatmacro.jl")

@static if VERSION < v"0.7.0-DEV.3500"
const REPL = Base.REPL
else
import REPL
end

if VERSION < v"0.7.0-DEV.3476"
@eval module Serialization
import Base.Serializer: serialize, deserialize, SerializationState, serialize_type
Expand Down
8 changes: 8 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ Random.seed!(rng, 1)
import Compat.Markdown
@test isa(Markdown.parse("foo"), Markdown.MD)

# 0.7.0-DEV.3500
module TestREPL
using Compat
using Compat.REPL
using Compat.Test
@test isdefined(@__MODULE__, :REPL)
end


# tests of removed functionality (i.e. justs tests Base)

Expand Down
8 changes: 0 additions & 8 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -329,14 +329,6 @@ end
# 0.7.0-DEV.3415
@test findall(x -> x==1, [1, 2, 3, 2, 1]) == [1, 5]

# 0.7.0-DEV.3500
module TestREPL
using Compat
using Compat.REPL
using Compat.Test
@test isdefined(@__MODULE__, :REPL)
end

# 0.7.0-DEV.3476
module TestSerialization
using Compat
Expand Down

0 comments on commit 0e88da2

Please sign in to comment.