Drop compat code for findall from #466 (and #467).

JuliaLang · Oct 8, 2019 · 1b9be3c · 1b9be3c
1 parent c74ee3a
commit 1b9be3c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -149,8 +149,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 * `module_name`, `Base.function_name`, and `Base.datatype_name` are now methods of a
   new function called `nameof` ([#25622]).
 
-* `find` is now `findall` ([#25545]).
-
 * `search` is now `findfirst`/`findnext` and `rsearch` is now `findlast`/`findprev`,
   sometimes combined with `isequal` or `in` ([#24673], [#26436]).
 

diff --git a/src/Compat.jl b/src/Compat.jl
@@ -71,12 +71,6 @@ end
     end
 end
 
-# 0.7.0-DEV.3415
-if !isdefined(Base, :findall)
-    const findall = find
-    export findall
-end
-
 @static if !isdefined(Base, :argmin)
     if VERSION >= v"0.7.0-DEV.1660" # indmin/indmax return key
         const argmin = indmin

diff --git a/test/old.jl b/test/old.jl
@@ -641,3 +641,6 @@ end
 @test length(Compat.CartesianIndices((1:1,))) == 1
 @test length(Compat.CartesianIndices((1:2,))) == 2
 @test length(Compat.CartesianIndices((1:2, -1:1))) == 6
+
+# 0.7.0-DEV.3415
+@test findall(x -> x==1, [1, 2, 3, 2, 1]) == [1, 5]
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -107,9 +107,6 @@ end
 @test argmin(Dict(:z=>10, :y=>12, :x=>9, :w=>11)) == :x
 @test argmin((1.0, -3, 0.f0)) == 2
 
-# 0.7.0-DEV.3415
-@test findall(x -> x==1, [1, 2, 3, 2, 1]) == [1, 5]
-
 module TestPkg
     using Compat
     using Compat.Pkg