Drop compat code for floatmin and floatmax from #607

JuliaLang · Oct 8, 2019 · f886239 · f886239
1 parent 0388309
commit f886239
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -75,8 +75,6 @@ Currently, the `@compat` macro supports the following syntaxes:
 
 ## Renaming
 
-* `realmin` and `realmax` are now `floatmin` and `floatmax` ([#28302])
-
 * `squeeze` is now `dropdims` ([#28303], [#26660]).
 
 ## New macros

diff --git a/src/Compat.jl b/src/Compat.jl
@@ -82,13 +82,6 @@ end
     end
 end
 
-# https://github.com/JuliaLang/julia/pull/28302
-if VERSION < v"0.7.0-beta2.169"
-    const floatmin = realmin
-    const floatmax = realmax
-    export floatmin, floatmax
-end
-
 # https://github.com/JuliaLang/julia/pull/28303
 if VERSION < v"0.7.0-beta2.143"
     export dropdims

diff --git a/test/old.jl b/test/old.jl
@@ -1264,3 +1264,8 @@ let a = rand(5,5)
         @test vec(S[i,:]) == sort(vec(a[i,:]))
     end
 end
+
+# 0.7.0-beta2.169
+@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
+@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
+@test floatmin(zero(Float64)) == floatmin(Float64)
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -98,11 +98,6 @@ let
     @test_throws UndefKeywordError func5(x=2)
 end
 
-# 0.7.0-beta2.169
-@test floatmin(Float16) == @eval $(Core.Intrinsics.bitcast(Float16, 0x0400))
-@test floatmax(Float32) == @eval $(Core.Intrinsics.bitcast(Float32, 0x7f7fffff))
-@test floatmin(zero(Float64)) == floatmin(Float64)
-
 # 0.7.0-beta2.143
 if VERSION < v"0.7.0-beta2.143"
     let a = reshape(Vector(1:4),(2,2,1,1)), b = reshape(Vector(1:4), (2,2,1))