Add .& and .| #306

nalimilan · 2017-01-14T21:00:42Z

These replace element-wise & and |, which are deprecated in Julia 0.6.
This syntax is not supported on 0.4 (raises a deprecation warning).

(Failure on nightlies is unrelated.)

tkelman · 2017-01-14T21:02:05Z

can this work in an at-compat macro on 0.4?

nalimilan · 2017-01-14T21:03:11Z

Not that I know of unfortunately. [1] .& [2] prints a deprecation warning on 0.4, even inside a macro.

nalimilan · 2017-01-14T21:08:42Z

And even worse, it sometimes does not parse at all:

julia> X .& Y

WARNING: deprecated syntax "X .".
Use "X." instead.
ERROR: syntax: extra token "Y" after end of expression

tkelman · 2017-01-14T21:11:58Z

test/runtests.jl

+
+# julia#17623
+if VERSION >= v"0.5.0"
+    @eval quote # To work around unsupported syntax on Julia 0.4


would at-static work here?

Doesn't exist on 0.4...

compat implements it

Ah, great. That works here, but not in the other file, since just parsing the syntax is an error.

I thought that's what at-static was supposed to help with. and it's exported so shouldn't need at-compat to use

@static doesn't really help parsing error. It can avoid lowering error if something parses but raises error/depwarn during lowering or type inference.

In the present case it fixes the error on 0.4, though the deprecation warnings remain.

tkelman · 2017-01-14T21:12:44Z

src/Compat.jl

+    # To work around unsupported syntax on Julia 0.4
+    parse("export .&, .|")
+    parse(".&(xs...) = broadcast(&, xs...)")
+    parse(".|(xs...) = broadcast(|, xs...)")


these will return Exprs, did you mean include_string ?

Of course, I got that totally wrong. Since I made the same mistake in tests, no wonder why they passed. :-)

at-static would look better here too

nalimilan · 2017-01-15T15:52:32Z

Another question to address: the PR currently replaces .& with broadcast(&, ...) on 0.5, but it could equally replace it with &. Which is better? Cc: @stevengj

nalimilan · 2017-01-17T21:27:34Z

Bump. This is needed to fix DataFrames on 0.6, among others.

tkelman · 2017-01-17T21:39:17Z

src/Compat.jl

@@ -1759,4 +1759,11 @@ if VERSION < v"0.5.0-dev+3669"
        scale!(similar(A, promote_op(*, eltype(A), eltype(D.diag))), D.diag, A)
 end

+if VERSION >= v"0.5.0" && VERSION < v"0.6.0-dev.1614"
+    # To work around unsupported syntax on Julia 0.4


do we know what would have made these first parse?

Sorry, I don't understand the question.

it was some pr during 0.5-dev that first made these parse, right? "parse more dot operators" by stevengj I want to say?

Yes: JuliaLang/julia#17393

OK, I've made the check specific to that commit.

stevengj · 2017-01-18T00:16:00Z

Would be nice if we could get CI working on nightly... I don't see a Compat issue for this?

These replace element-wise & and |, which are deprecated in Julia 0.6. This syntax is not supported by Julia 0.4.

nalimilan · 2017-01-18T09:26:41Z

AppVeyor failure due to network error.

nalimilan · 2017-01-18T21:34:26Z

Good to go now?

tkelman · 2017-02-04T05:40:31Z

src/Compat.jl

@@ -1759,4 +1759,11 @@ if VERSION < v"0.5.0-dev+3669"
        scale!(similar(A, promote_op(*, eltype(A), eltype(D.diag))), D.diag, A)
 end

+if VERSION >= v"0.5.0-dev+5509" && VERSION < v"0.6.0-dev.1614"


how did you get the 1614 cutoff? I think that's wrong, I get 1632 at the merge commit b0a41531fc4a0345710375adb3d7f40b6220ae91

1614 corresponds to commit JuliaLang/julia@f216cbb, from JuliaLang/julia#17623 for which 1632 is the merge commit. Which is the most correct?

The merge commit. Otherwise you're counting relative to where work on the PR branched off from, and there's going to be overlap for commits from master that don't have the feature. Linear numbering isn't quite sufficient to capture "newer or older than a given commit" so we should probably move towards feature tests where possible.

OK, see #318.

stevengj · 2017-02-04T13:39:28Z

@nalimilan, & is probably faster on 0.5, but I don't think it's critical for Compat to use the fastest possible code on older releases.

worth noting the method definition of this as broadcast is implemented by Compat on 0.5 JuliaLang/Compat.jl#306

Were added in #306.

* Remove `take!(::Task)` definition for Julia versions prior to 0.6 Was added in #307. * Remove `redirect_std*(f, stream)` definitions for Julia prior to v0.6 Were added in #275. * Remove at-__DIR__ macro definition for Julia versions prior to 0.6 Was added in #281. * Remove `broadcast` definition for equal-length tuples Was added in #324 and #328 * Remove definitions of `unsafe_get` and `isnull` fallsback Were added in #287. * Remove defintions of `xor` and `⊻` Were added in #289. * Definitions of `numerator` and `denominator` Were added in #290. * Remove defintion of `iszero` Was added in #305. * Remove definition of `>:` Was added in #336 * Remove definition of `take!(::Base.AbstractIOBuffer)` Was added in #290. * Remove definiton of `.&` and `.|` Were added in #306. * Remove definition of `Compat.isapprox` Was added in #309.

tkelman reviewed Jan 14, 2017

View reviewed changes

nalimilan force-pushed the nl/ops branch from 5860ba0 to c9ea21c Compare January 14, 2017 21:18

nalimilan mentioned this pull request Jan 14, 2017

Fix tests and deprecations on Julia 0.6 JuliaData/DataFrames.jl#1146

Closed

nalimilan force-pushed the nl/ops branch 2 times, most recently from fcd3b92 to 19e0370 Compare January 14, 2017 21:59

yuyichao mentioned this pull request Jan 14, 2017

Fix 0.6 depwarns JuliaImages/Images.jl#573

Merged

nalimilan force-pushed the nl/ops branch from 19e0370 to d2b16ae Compare January 14, 2017 23:02

nalimilan mentioned this pull request Jan 15, 2017

Rewrite broadcast() and map() based on lift() JuliaStats/NullableArrays.jl#166

Merged

tkelman reviewed Jan 17, 2017

View reviewed changes

ararslan requested a review from stevengj January 17, 2017 22:18

stevengj approved these changes Jan 18, 2017

View reviewed changes

nalimilan force-pushed the nl/ops branch from d2b16ae to 378c57f Compare January 18, 2017 09:09

Add .& and .|

4e49ddb

These replace element-wise & and |, which are deprecated in Julia 0.6. This syntax is not supported by Julia 0.4.

nalimilan force-pushed the nl/ops branch from 378c57f to 4e49ddb Compare January 18, 2017 09:26

nalimilan closed this Jan 18, 2017

nalimilan reopened this Jan 18, 2017

ararslan merged commit e96a5e8 into master Jan 18, 2017

ararslan deleted the nl/ops branch January 18, 2017 21:37

tkelman reviewed Feb 4, 2017

View reviewed changes

nalimilan mentioned this pull request Feb 4, 2017

Fix version check for .& and .| #318

Merged

tkelman added a commit to SciML/DiffEqPDEBase.jl that referenced this pull request Apr 5, 2017

use more specific VERSION cutoff for converting .| result to BitArray

72e34b3

worth noting the method definition of this as broadcast is implemented by Compat on 0.5 JuliaLang/Compat.jl#306

tkelman mentioned this pull request Apr 5, 2017

use more specific VERSION cutoff for converting .| result to BitArray SciML/DiffEqPDEBase.jl#2

Merged

martinholters added a commit that referenced this pull request Aug 31, 2018

Remove definiton of .& and .|

5ec209b

Were added in #306.

martinholters added a commit that referenced this pull request Aug 31, 2018

Remove definiton of .& and .|

94b7e38

Were added in #306.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add .& and .| #306

Add .& and .| #306

nalimilan commented Jan 14, 2017

tkelman commented Jan 14, 2017

nalimilan commented Jan 14, 2017

nalimilan commented Jan 14, 2017

tkelman Jan 14, 2017

nalimilan Jan 14, 2017

tkelman Jan 14, 2017

nalimilan Jan 14, 2017

tkelman Jan 14, 2017

yuyichao Jan 14, 2017

nalimilan Jan 14, 2017

tkelman Jan 14, 2017

nalimilan Jan 14, 2017

tkelman Jan 14, 2017

nalimilan commented Jan 15, 2017

nalimilan commented Jan 17, 2017

tkelman Jan 17, 2017

nalimilan Jan 17, 2017

tkelman Jan 17, 2017

ararslan Jan 17, 2017

nalimilan Jan 18, 2017

stevengj commented Jan 18, 2017

nalimilan commented Jan 18, 2017

nalimilan commented Jan 18, 2017

tkelman Feb 4, 2017

nalimilan Feb 4, 2017

tkelman Feb 4, 2017

nalimilan Feb 4, 2017

stevengj commented Feb 4, 2017

Add .& and .| #306

Add .& and .| #306

Conversation

nalimilan commented Jan 14, 2017

tkelman commented Jan 14, 2017

nalimilan commented Jan 14, 2017

nalimilan commented Jan 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nalimilan commented Jan 15, 2017

nalimilan commented Jan 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevengj commented Jan 18, 2017

nalimilan commented Jan 18, 2017

nalimilan commented Jan 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevengj commented Feb 4, 2017