Neither advertise the functions moved to StatsBase nor test them on 0.7 #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, what works right now (well, with sufficiently recent StatsBase) is this e.g. pattern: I don't think that is something we should be advertising, though. |
martinholters
force-pushed
the
mh/statsbase
branch
from
b17349a
to
ee582ae
Compare
|
Known unrelated OSX failure. |
|
Maybe we should still run the tests on Julia 0.6? Packages can already rely on these functions and we really don't want to break them there. |
|
True. OTOH, once JuliaStats/StatsBase.jl#382 has landed, I'd add deprecation warnings here to make people switch to |
These functions call through to Base functions, which is rendered impossible after their moval to StatsBase (JuliaLang/julia#27152). As StatsBase is using Compat, Compat cannot use StatsBase. In the future, these functions should print deprecation warinings also on 0.6, telling people how to get the desired functionality, once that is settled. Alternatively, we could duplicate the code now moved to StatsBase in Compat.
martinholters
force-pushed
the
mh/statsbase
branch
from
ee582ae
to
facb7ec
Compare
nalimilan
approved these changes
May 30, 2018
|
Barring objections, I'll merge later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions call through to Base functions, which is rendered impossible after their moval to StatsBase (JuliaLang/julia#27152). As StatsBase is using Compat, Compat cannot use StatsBase. In the future, these functions should print deprecation warnings also on 0.6, telling people how to get the desired functionality, once that is settled (see discussion in JuliaStats/StatsBase.jl#379).
Alternatively, we could duplicate the code now moved to StatsBase in Compat.