Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weed out relicts from at-compat #626

Merged
merged 8 commits into from
Aug 31, 2018
Merged

Weed out relicts from at-compat #626

merged 8 commits into from
Aug 31, 2018

Conversation

martinholters
Copy link
Member

In the spirit of #449, but just a subset to facilitate review (best done commit by commit, I guess). Compat.collect ended up here, too, because its README entry was in the syntaxes section.

I've manually verified the deleted tests still pass.

@martinholters
Remove at-compat for type aliases
3947c62 
Was added in #326, now obsolete as no longer required on minimum
supported Julia version 0.6.
@martinholters
Remove at-compat for Nullable construction
3479138 
Was added in #287, now obsolete as no longer required on minimum 
supported Julia version 0.6.
@martinholters
Remove at-compat for Foo{<:Bar} sugar
87588a6 
Was added in #317 (and #336), now obsolete as no longer required on 
minimum supported Julia version 0.6.
@martinholters
Remove at-compat for index styles
89fc03f 
Was added in #329, now obsolete as no longer required on minimum 
supported Julia version 0.6.
@martinholters
Remove at-compat for type declarations
aa33054 
Was added in #325, now obsolete as no longer required on minimum 
supported Julia version 0.6.
@martinholters
Remove unused at-compat helper functions
e202d6f
@martinholters
Remove README entries for removed at-compat functionality
ba2b5b7 
* new style call overloading (added in #181, removed in #385)
* `get(io, s false)` (added in #212, #215, #225, removed in #385)
* `.=` (added in #292 and #316, removed in #372)
@martinholters
Remove Compat.collect(A)
cfce90c 
Was added in #350 and #351, now obsolete as no longer required on 
minimum supported Julia version 0.6.
@martinholters
Copy link
Member Author

Anyone care to take a look at this?

@martinholters
Copy link
Member Author

Will merge tomorrow unless anyone objects.

@martinholters martinholters merged commit 96e41ae into master Aug 31, 2018
@martinholters martinholters deleted the mh/cleanup_at_compat branch August 31, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinholters