Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a small precompile workload #226

Merged
merged 1 commit into from
May 3, 2023
Merged

add a small precompile workload #226

merged 1 commit into from
May 3, 2023

Conversation

KristofferC
Copy link
Sponsor Member

Using

@time @eval Downloads.download("https://pkg.julialang.org/registries", tempname())

as a test (because that is the end function I am interested in) we get on master:

0.838721 seconds (489.98 k allocations: 34.457 MiB, 41.40% compilation time)

and with this PR:

0.484503 seconds (31.97 k allocations: 2.184 MiB, 4.42% compilation time)

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #226 (a840de1) into master (3ed0f08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files           5        5           
  Lines         575      575           
=======================================
  Hits          519      519           
  Misses         56       56           
Impacted Files Coverage Δ
src/Downloads.jl 85.58% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@StefanKarpinski
Copy link
Sponsor Member

Does an extra half a second on the first download really matter?

@KristofferC
Copy link
Sponsor Member Author

Yes. 0.5s * many things becomes many seconds. This is one small piece of a larger puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants