Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Multi timers atexit. Add 1.6 CI #234

Merged
merged 15 commits into from
Jan 13, 2024
Merged

Close Multi timers atexit. Add 1.6 CI #234

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7ee3156
fix timers
IanButterworth Jan 11, 2024
f4cfda7
register one function
IanButterworth Jan 11, 2024
1bc36b9
capitalization
IanButterworth Jan 11, 2024
82b8da5
capitalization fixup
IanButterworth Jan 11, 2024
a5ae02e
collect Multis as weak refs for atexit cleanup
IanButterworth Jan 12, 2024
4712512
revert previous workaround
IanButterworth Jan 12, 2024
79fbe38
make work on older julia versions
IanButterworth Jan 12, 2024
128d1a8
Revert "make work on older julia versions"
IanButterworth Jan 12, 2024
fa7940b
suggestions
IanButterworth Jan 12, 2024
a27a0da
bump julia compat to 1.6
IanButterworth Jan 12, 2024
aa0b112
update CI
IanButterworth Jan 12, 2024
06f103c
qualify `Base.@lock`
IanButterworth Jan 12, 2024
ab8a69a
go back to 1.3 but keep 1.6 CI
IanButterworth Jan 12, 2024
ed67afe
import `@lock` properly
IanButterworth Jan 12, 2024
ab79e25
skip windows 1.3 CI
IanButterworth Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Curl/Multi.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ function remove_handle(multi::Multi, easy::Easy)
done!(multi)
end
end
Base.atexit() do
close(multi.timer)
end
end
unpreserve_handle(multi)
end
Expand Down Expand Up @@ -134,6 +137,9 @@ function timer_callback(
do_multi(multi)
end
end
Base.atexit() do
close(multi.timer)
end
elseif timeout_ms != -1
@async @error("timer_callback: invalid timeout value", timeout_ms, maxlog=1_000)
return -1
Expand Down
Loading