Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions for CI #55

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Add GitHub Actions for CI #55

merged 3 commits into from
Dec 4, 2020

Conversation

nalimilan
Copy link
Member

Based on the PkgTemplates file.

Updated version of #52, with support for 32-bit (which is essential if we expect packages to run there).

Based on the PkgTemplates file.
@fredrikekre
Copy link
Member

32 runs of CI :)

@nalimilan
Copy link
Member Author

Yeah it's a lot. I guess we could disable a few of them (e.g. only keep one 32-bit run), but not sure which ones.

@fredrikekre
Copy link
Member

I suggest commenting out such that only latest 1.x is run on the three OSs or something like that.

@rikhuijzer
Copy link
Contributor

Shouldn't the separate travis and codecov files also be removed?

@nalimilan
Copy link
Member Author

OK, I've tried something: test all platforms with latest Julia, test all Julia versions on 64-bit and 32-bit Linux. That gives 9 builds.

Shouldn't the separate travis and codecov files also be removed?

We can probably do that, but that's not strictly necessary so I'm not sure. Probably better discuss this as a second step.

Copy link
Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the travis, codecov and AV files after this

@nalimilan nalimilan merged commit 01cb16d into master Dec 4, 2020
@nalimilan nalimilan deleted the nl/GitHubActions branch December 4, 2020 10:52
@nalimilan
Copy link
Member Author

Of course I got the badge wrong! See #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants