Capture the parent message locally for idle messages #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@async no longer implicitly captures variables (https://github.com/JuliaLang/julia/19468)
stevengj
reviewed
Jan 23, 2018
src/eventloop.jl
Outdated
| sleep(idle_delay[]) | ||
| flush_all() | ||
| send_status("idle", msg) | ||
| let msg = msg |
There was a problem hiding this comment.
maybe add a comment referencing this PR or JuliaLang/julia#19594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Julia 0.6, I am receiving idle messages with the wrong parent message ID. This only happens when there are multiple execute requests queued up. As an example, if you run the cell
sleep(3)Then
sleep(2)Where
sleep(2)is sent to the kernel beforesleep(3)is finished executing, the idle message meant forsleep(3)will actually have the parent header of thesleep(2)request. It seems to be related to JuliaLang/julia#19594 which removes the behavior of@asyncto implicitly capture local variables.