Cleanup and fix operator predicates #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove big lists of operator kinds and inscrutable hardcoded unicode ranges in predicates. Instead, generate all this code directly from the table of operator kinds. This makes new operators much easier to add in a single place in the code, thereby fixing a few bugs/inconsistencies which have crept in over time as new operators were added. Also fix several bugs in the tokenizer where `is_operator_start_char()` was used, but the check should have been restricted to dottable operators.
Now that this code is much cleaner and shorter it makes sense to have the whole lexer in one file.
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 96.57% 96.65% +0.08%
==========================================
Files 15 14 -1
Lines 3999 4005 +6
==========================================
+ Hits 3862 3871 +9
+ Misses 137 134 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove big lists of operator kinds and inscrutable hardcoded unicode
ranges in predicates. Instead, generate all this code directly from the
table of operator kinds.
This makes new operators much easier to add in a single place in the
code, thereby fixing a few bugs/inconsistencies which have crept in over
time as new operators were added.
Also fix several bugs in the tokenizer where
is_operator_start_char()was used, but the check should have been restricted to dottable
operators.