Reference parser compat: Make toplevel error Exprs more compatible #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering a toplevel error, the reference parser * truncates the top level expression arg list before that error * includes the last line number * appends the error message Do something similar here so that the associated `LoadError` shows a more reasonable line number.
11 tasks
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 96.68% 96.69% +0.01%
==========================================
Files 14 14
Lines 4011 4028 +17
==========================================
+ Hits 3878 3895 +17
Misses 133 133
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering a toplevel error, the reference parser
Do something similar here so that the associated
LoadErrorshows a more reasonable line number.