Also disallow bare generators in interpolation syntax #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
force-pushed
the
c42f/string-interpolate-error
branch
from
7d23151
to
29245bb
Compare
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 96.80% 96.81%
=======================================
Files 14 14
Lines 4104 4107 +3
=======================================
+ Hits 3973 3976 +3
Misses 131 131
|
This should be the only other case which needs to be disallowed - the reference parser uses parse_eq_star here and that's also what's used within parse_brackets with `,` `;` and `for` being the only allowed continuation tokens. Also refine error recovery a little and add additional tests.
c42f
force-pushed
the
c42f/string-interpolate-error
branch
from
29245bb
to
9a6e509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the only other case which needs to be disallowed - the reference parser uses parse_eq_star here and that's also what's used within parse_brackets with
,;andforbeing the only allowed continuation tokens.Also refine error recovery a little and add additional tests.
Additional fix for #306