Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/document source code access functions + add filename() #470

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

c42f
Copy link
Member

@c42f c42f commented Jul 21, 2024

  • Move all source code access functions which refer to source locations and strings into the top of source_files.jl, and add some documentation for these.
  • Add filename() function to determine source file name of a syntax object
  • Also add a minor generalization to SyntaxNode->Expr conversion code to make Expr conversion general enough to allow it to also be used for JuliaLowering.SyntaxTree. (internal/experimental interface, for now)

* Move all source code access functions which refer to source locations
  and strings into the top of source_files.jl, and add some
  documentation for these.
* Add `filename()` function to determine source file name of a syntax
  object
* Also add a minor generalization to SyntaxNode->Expr conversion code to
  make Expr conversion general enough to allow it to also be used for
  JuliaLowering.SyntaxTree. (internal/experimental interface, for now)
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (dbe9e5d) to head (c04ccc2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   96.55%   96.09%   -0.47%     
==========================================
  Files          14       13       -1     
  Lines        4244     3990     -254     
==========================================
- Hits         4098     3834     -264     
- Misses        146      156      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c42f c42f merged commit 3dbcd32 into main Jul 21, 2024
38 checks passed
@c42f c42f deleted the caf/source-access-cleanup branch July 21, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant