Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any of ≔ ⩴ ≕ as identifiers #478

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

c42f
Copy link
Member

@c42f c42f commented Jul 30, 2024

These assignment-precedence operators shouldn't be special syntax and should instead be usable as normal identifiers just like ~.

Fix #405

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (835a527) to head (bc74f27).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   96.75%   96.08%   -0.68%     
==========================================
  Files          14       13       -1     
  Lines        4259     4008     -251     
==========================================
- Hits         4121     3851     -270     
- Misses        138      157      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These assignment-precedence operators shouldn't be special syntax and
should instead be usable as normal identifiers just like `~`.

Also add more test cases for the true syntactic operators.
@c42f c42f force-pushed the caf/fix-nonsyntactic-assignment-ops branch from bc74f27 to de82b6f Compare July 30, 2024 11:53
@c42f c42f merged commit 21c6774 into main Jul 31, 2024
36 checks passed
@c42f c42f deleted the caf/fix-nonsyntactic-assignment-ops branch July 31, 2024 01:34
@c42f c42f mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

≔ (\coloneq) generates "invalid identifier" error
1 participant