Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume that SubString has pointer and copy instead #506

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Don't assume that SubString has pointer and copy instead #506

merged 5 commits into from
Oct 6, 2024

Conversation

LilithHafner
Copy link
Member

  • Still assume Substring{String} has pointer
  • Add tests

Fixes #505

KristofferC
KristofferC reviewed Sep 16, 2024
View reviewed changes
test/parse_stream.jl Outdated Show resolved Hide resolved
c42f
c42f approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks ❤️

@c42f
Copy link
Member

c42f commented Oct 6, 2024

The test failure here seems to just be one CI machine having a bad day 🤷‍♀️

@LilithHafner LilithHafner merged commit ad5e2b9 into main Oct 6, 2024
36 checks passed
@LilithHafner LilithHafner deleted the lh/copy-substring-abstractstring branch October 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@c42f c42f c42f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: JuliaSyntax parser failed — falling back to flisp!
3 participants
@LilithHafner @c42f @KristofferC