WIP: Set up CI etc #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/CI
branch
4 times, most recently
from
ebfce8d to
afc5fac
Compare
|
The tests are so horribly made that they take forever to run so I think we need to run this on dedicated hardware and in parallel. |
fredrikekre
reviewed
Nov 14, 2024
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
|
Can we reduce the number of tests but without significantly losing coverage? Maybe a major exercise. I suppose the easiest thing is to do the excision with the same test suite (use buildkite the way we do with LBT tests) and then hopefully over time clean up the testsuite. |
|
That's the plan, just throw our buildkite hardware resources at it and run it in parallel to not block this on anything. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 2, 2024
This PR validates the input parameters to the Julia LAPACK wrappers, so
that the error messages are more informative.
On nightly
```julia
julia> using LinearAlgebra
julia> LAPACK.geev!('X', 'X', rand(2,2))
** On entry to DGEEV parameter number 1 had an illegal value
ERROR: ArgumentError: invalid argument #1 to LAPACK call
```
This PR
```julia
julia> using LinearAlgebra
julia> LAPACK.geev!('X', 'X', rand(2,2))
ERROR: ArgumentError: argument #1: jobvl must be one of ('N', 'V'), but 'X' was passed
```
Secondly, moved certain allocations (e.g. in `geevx`) below the
validation checks, so that these only happen for valid parameter values.
Thirdly, added `require_one_based_indexing` checks to functions where
these were missing.
(cherry picked from commit dcd1fb2148dd7affee9449e304a9b42e7feba1ce)
(cherry picked from commit 0087a1177509a6e70ff122636b0f7b6c596ce102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.