Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange tests #1157

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rearrange tests #1157

wants to merge 4 commits into from

Conversation

dkarrasch
Copy link
Member

This brutally splits the triangular tests in two parts, and creates a dedicated test file for unitful tests. That should spread the load more evenly among several workers, when present.

To the best of my knowledge, this doesn't change any test overall. Mostly, this is copy-paste.

@dkarrasch
Copy link
Member Author

The unitful tests take off some heavy load from the bidiag.jl test suite, and the triangular.jl tests include only the initial big (nested) loops. All other parts are moved to triangular2.jl.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (959d985) to head (d425706).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   91.84%   91.81%   -0.03%     
==========================================
  Files          34       34              
  Lines       15357    15357              
==========================================
- Hits        14104    14100       -4     
- Misses       1253     1257       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkarrasch
Copy link
Member Author

Hm, I missed to check upfront. So the triangular split doesn't yield much, the first block is the very dominant part, so we might as well keep the triangular tests as is. Though any reduction of its runtime is welcome, since this worker runs from start to end and determines the total runtime. I'll check the effect of removing the unitful tests from bidiag.jl tomorrow.

@dkarrasch
Copy link
Member Author

This looks much much better now! Comments welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant