Bundle Project.toml with libraries
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 83.87% 83.92% +0.04%
==========================================
Files 3 3
Lines 732 734 +2
==========================================
+ Hits 614 616 +2
Misses 118 118
|
|
@KristofferC @IanButterworth this is ready for review from my point of view. |
|
Thanks a lot for the fast response! It would be great if you could also tag a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #572, this PR bundles the
Project.tomlfile with libraries. The motivation is that otherwise it is not possible to run dynamic code in the library that isusingone of the project dependencies. For example, whenincludeing a file from a library function,using MyPkgwill currently not work even ifMyPkgis listed in the[deps]section of the project dir. With this PR,using MyPkgwill be possible again.I also added a note to the docstring explaining that installing multiple apps/libraries to the same prefix is generally not possible, since they will overwrite each other's
Project.tomlin<prefix>/share/julia. This was already the case before for apps, I just amended the documentation for it.