Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions CI #2166

Closed
wants to merge 3 commits into from

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 25, 2020

I thought it would be worth seeing how CI runs on github actions, given it can be pretty slow on appveyor, and travis has recently been a bit slow to respond

One of the options mentioned in #2066

The actions won't appear here until this is merged, or this PR is replicated on a non-fork branch.
You can see them here IanButterworth#1 (the coverage processing step will fail on each on that fork)

@IanButterworth IanButterworth force-pushed the ib/gha_ci branch 2 times, most recently from 54c5a91 to 0db1b26 Compare October 25, 2020 03:37
@IanButterworth
Copy link
Member Author

There appears to be some odd TEMP dir issues on windows:
https://github.com/ianshmean/Pkg.jl/runs/1303945893?check_suite_focus=true#step:5:811

Seems to be actions/runner-images#712
but the recommended fix isn't working (or perhaps done in the right way)

@DilumAluthge
Copy link
Member

@ianshmean @KristofferC I'd recommend replacing the on: section with this:

on:
  pull_request:
    branches:
      - master
  push:
    branches:
      - master
    tags: '*'

That way, CI will actually run on pull requests. (Right now, it will not run on pull requests.)

@KristofferC
Copy link
Member

What causes it not to run now?

@DilumAluthge
Copy link
Member

Hmm. Are actions enabled for this repo? Go to Settings and click on Actions in the left hand sidebar.

@KristofferC
Copy link
Member

Looks like it

image

@DilumAluthge
Copy link
Member

Really strange.

@DilumAluthge
Copy link
Member

Try merging this PR and let's see if it runs on master?

@DilumAluthge
Copy link
Member

@KristofferC
Copy link
Member

JuliaLang allows any actions as well. When I made a PR to another repo JuliaLang/TOML.jl#12 they should up straight away.

@DilumAluthge
Copy link
Member

Might be a syntax error in the workflow.

Or a fork issue.

@KristofferC how about you:

  1. Make a PR from a branch inside this repo.
  2. Copy a workflow file that you have used before (e.g. add github actions CI TOML.jl#12) so we know the syntax works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants