WIP: Support for weak dependencies #3216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
KristofferC
force-pushed
the
kc/weak_deps
branch
from
b30f943 to
40318a3
Compare
Seelengrab
reviewed
Oct 4, 2022
docs/src/weakdeps.md
Outdated
| It is sometimes desirable to be able to extend some functionality of a package without having to | ||
| unconditionally take on the cost (in terms of e.g. load time) of adding an extra dependency. | ||
| A *weak* dependency is a package that is only available to load if some other package in the | ||
| current environment have that package as a normal (or strong) dependency. |
There was a problem hiding this comment.
Suggested change
| current environment have that package as a normal (or strong) dependency. | |
| current environment has that package as a normal (or strong) dependency. |
Seelengrab
reviewed
Oct 4, 2022
docs/src/weakdeps.md
Outdated
|
|
||
| Weak dependencies are listed in a `Project.toml` file under the `[weakdeps]` section which can be compared to a | ||
| (strong) dependency which is under the `[deps]` section. | ||
| Compatibility on weak dependencies are specified like a normal dependeny unde the ´[compat]` section. |
There was a problem hiding this comment.
Suggested change
| Compatibility on weak dependencies are specified like a normal dependeny unde the ´[compat]` section. | |
| Compatibility on weak dependencies are specified like a normal dependency under the `[compat]` section. |
There was a problem hiding this comment.
Thanks, the current docs are still very WIP.
Seelengrab
reviewed
Oct 4, 2022
|
|
||
| if Base.@hasdep Contour | ||
| using Contour | ||
| function plot(c::Contour.ContourCollection |
There was a problem hiding this comment.
Suggested change
| function plot(c::Contour.ContourCollection | |
| function plot(c::Contour.ContourCollection) |
Seelengrab
reviewed
Oct 4, 2022
docs/src/weakdeps.md
Outdated
| ## Compatibility with older Julia versions. | ||
|
|
||
| It is possible to have a dependency be a weak version in Julia versions that support it and be a strong dependency in earlier | ||
| Julia versions. This is done by having the dependency as *both* a strong and weak dependency. Older Julia version will ignore |
There was a problem hiding this comment.
Suggested change
| Julia versions. This is done by having the dependency as *both* a strong and weak dependency. Older Julia version will ignore | |
| Julia versions. This is done by having the dependency as *both* a strong and weak dependency. Older Julia versions will ignore |
Seelengrab
reviewed
Oct 4, 2022
docs/src/weakdeps.md
Outdated
|
|
||
| It is possible to have a dependency be a weak version in Julia versions that support it and be a strong dependency in earlier | ||
| Julia versions. This is done by having the dependency as *both* a strong and weak dependency. Older Julia version will ignore | ||
| the specificaton of the depenency as weak while new Julia versions will tag it as a weak dependency. |
There was a problem hiding this comment.
Suggested change
| the specificaton of the depenency as weak while new Julia versions will tag it as a weak dependency. | |
| the specification of the dependency as weak while new Julia versions will tag it as a weak dependency. |
Seelengrab
reviewed
Oct 4, 2022
|
|
||
| if !isdefined(Base, :hasdep) || Base.hasdep(@__MODULE__, :Contour) | ||
| using Contour | ||
| function plot(c::Contour.ContourCollection |
There was a problem hiding this comment.
Suggested change
| function plot(c::Contour.ContourCollection | |
| function plot(c::Contour.ContourCollection) |
Seelengrab
reviewed
Oct 4, 2022
| old_num_promoted = count(in(old_uuids), weak_uuids) | ||
| new_num_promoted = count(in(new_uuids), weak_uuids) | ||
|
|
||
| # @show pkgentry pkgentry.weakdeps old_uuids new_uuids new_num_promoted old_num_promoted |
There was a problem hiding this comment.
Suggested change
| # @show pkgentry pkgentry.weakdeps old_uuids new_uuids new_num_promoted old_num_promoted |
KristofferC
force-pushed
the
kc/weak_deps
branch
2 times, most recently
from
6b6d479 to
9d7a180
Compare
KristofferC
force-pushed
the
kc/weak_deps
branch
from
9d7a180 to
f9cd4c4
Compare
|
Closing because package extensions won #3264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaLang/julia#47040