Fix broken source_path handling. Explicitly test for coverage files #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/ext_coverage
branch
from
e3cea69 to
6715334
Compare
IanButterworth
force-pushed
the
ib/ext_coverage
branch
from
6715334 to
eadbc16
Compare
IanButterworth
changed the title
KristofferC
reviewed
Dec 21, 2022
| @@ -1,6 +1,7 @@ | |||
| module OffsetArraysExt | |||
|
|
|||
| using HasExtensions, OffsetArrays | |||
| import HasExtensions: foo | |||
fredrikekre
approved these changes
Dec 21, 2022
KristofferC
reviewed
Dec 21, 2022
| Pkg.test(TEST_PKG.name; coverage=true) | ||
| pkgdir = Base.locate_package(Base.PkgId(TEST_PKG.uuid, TEST_PKG.name)) | ||
| # No coverage files being generated? | ||
| @test_broken TEST_PKG.name * ".cov" in readdir(pkgdir) |
There was a problem hiding this comment.
Coverage files now have a PID, so maybe just not looking for the correct files?
There was a problem hiding this comment.
Also pkgdir here is the source file not the src dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear to me why this didn't fail in #3281 .Urgh.. it was picking up a function and string-ing the name 🤦♂️This fixes a rather nasty missing local var bug introduced by #3281 that broke coverage generation in
Pkg.test, and reinstates and expands testing for coverage files where they should and shouldn't be generated