Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct threads specification for subprocess #3467

Merged
merged 2 commits into from
May 17, 2023

Conversation

kpamnany
Copy link
Contributor

Fixes #3395.

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kpamnany. LGTM! But i'll let one of the Pkg devs give final approval.

@IanButterworth
Copy link
Member

Seems reasonable to me given that the previous threads setup was forwarded

@IanButterworth IanButterworth merged commit 9f277c4 into master May 17, 2023
@IanButterworth IanButterworth deleted the kp/fix-test-threads branch May 17, 2023 03:03
IanButterworth pushed a commit to IanButterworth/Pkg.jl that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test environment doesn't inherit number of interactive threads
4 participants