Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gc in prescence of normal files #634

Merged
merged 1 commit into from
Aug 13, 2018
Merged

fix gc in prescence of normal files #634

merged 1 commit into from
Aug 13, 2018

Conversation

KristofferC
Copy link
Member

Fixes #601

@KristofferC
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 13, 2018
@bors @KristofferC
Merge #634
83315b3 
634: fix gc in prescence of normal files r=KristofferC a=KristofferC

Fixes #601 

Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 13, 2018

Timed out

@fredrikekre
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Aug 13, 2018
@bors @fredrikekre @KristofferC
Merge #618 #631 #634
0a4ab77 
618: better info messages for activating new env r=fredrikekre a=fredrikekre



631: stop testing on 0.7 r=KristofferC a=KristofferC

No point

634: fix gc in prescence of normal files r=KristofferC a=KristofferC

Fixes #601 

Co-authored-by: Fredrik Ekre <fredrik.ekre@chalmers.se>
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #634 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   90.94%   91.76%   +0.82%     
==========================================
  Files          17       17              
  Lines        2937     2939       +2     
==========================================
+ Hits         2671     2697      +26     
+ Misses        266      242      -24
Impacted Files Coverage Δ
src/API.jl 89.96% <100%> (+8.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69406bf...a3561e4. Read the comment docs.

@KristofferC
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 13, 2018

Canceled

@KristofferC
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 13, 2018
@bors @KristofferC
Merge #634
f2107ec 
634: fix gc in prescence of normal files r=KristofferC a=KristofferC

Fixes #601 

Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 13, 2018

Build succeeded

@bors bors bot merged commit a3561e4 into master Aug 13, 2018
@fredrikekre fredrikekre deleted the kc/ds_stor_hurrdurr branch August 13, 2018 14:19
@KristofferC KristofferC mentioned this pull request Aug 20, 2018
Merged
22 tasks
@KristofferC KristofferC mentioned this pull request Sep 18, 2018
Closed
@fredrikekre fredrikekre mentioned this pull request Oct 2, 2018
Closed
@fredrikekre fredrikekre mentioned this pull request Oct 12, 2018
Closed
@fredrikekre fredrikekre mentioned this pull request Oct 19, 2018
Merged
@00vareladavid 00vareladavid added bug and removed Bug2 labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gc error with .DS_Store
4 participants
@KristofferC @fredrikekre @codecov-io @00vareladavid