Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer can_inline to subprocess #870

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Transfer can_inline to subprocess #870

merged 2 commits into from
Nov 6, 2018

Conversation

fingolfin
Copy link
Contributor

This is meant as an alternative to PR #866 for resolving issue #865

@fingolfin fingolfin mentioned this pull request Nov 2, 2018
Closed
@StefanKarpinski
Copy link
Sponsor Member

bors r+

@StefanKarpinski
Copy link
Sponsor Member

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 6, 2018

Canceled

@StefanKarpinski
Copy link
Sponsor Member

@KristofferC is going to reword the doc a bit and then we'll merge this.

@KristofferC
Copy link
Sponsor Member

bors r+

bors bot added a commit that referenced this pull request Nov 6, 2018
@bors @fingolfin @KristofferC
Merge #870
d41a269 
870: Transfer can_inline to subprocess r=KristofferC a=fingolfin

This is meant as an alternative to PR #866 for resolving issue #865

Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Kristoffer Carlsson <kristoffer.carlsson@chalmers.se>
@bors
Copy link
Contributor

bors bot commented Nov 6, 2018

Build succeeded

@bors bors bot merged commit 73155d3 into JuliaLang:master Nov 6, 2018
@fredrikekre fredrikekre mentioned this pull request Nov 8, 2018
Merged
@00vareladavid 00vareladavid mentioned this pull request Nov 25, 2018
Closed
@diegozea
Copy link

diegozea commented Dec 3, 2018

@tkelman @ninjin @staticfloat @simonbyrne Should the default Travis CI script for Julia use this inline=no when codecov or coveralls is set to true ? I'm using the default scripts and I'm seeing the coverage drop reported in JuliaCI/Coverage.jl#187

@KristofferC
Copy link
Sponsor Member

Only if we make coverage=false the default because inline=no is typically too slow to be usable in my experience.

@StefanKarpinski
Copy link
Sponsor Member

Please don't ping so many people—everyone who watches this repo will already get this.

@diegozea
Copy link

diegozea commented Dec 3, 2018

I'm sorry. I've just used the list suggested by Travis CI docs without checking the list of watchers.

@StefanKarpinski
Copy link
Sponsor Member

Hah, ok, you did follow the instructions exactly. Those instructions should be updated!

@fingolfin fingolfin deleted the mh/no-inline2 branch March 11, 2019 11:20
@ronisbr ronisbr mentioned this pull request Apr 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @StefanKarpinski @KristofferC @diegozea