Treat printing as more than a nothing-return write #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecosaur
force-pushed
the
quickfix
branch
2 times, most recently
from
64343fa
to
34b91fc
Compare
As raised in <JuliaLang/julia#55198>, once we look at AbstractString types outside of Core/Base, their print methods can be meaningfully different to write + returning nothing. As such, instead of delegating printing to write, we need to call _ansi_writer asking it to use the print function.
|
Tests for fixes like this are good (commenting since this will also be put into Julia itself). |
|
I do try to generally add tests for things like this, but this is a situation that only came up with non-Base string type, which makes coming up with a nice minimal test a bit harder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in JuliaLang/julia#55198, once we look at
AbstractStringtypes outside of Core/Base, theirprintmethods can be meaningfully different towrite+ returningnothing.As such, instead of delegating printing to
write, we need to call_ansi_writerasking it to use theprintfunction.