Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ternery instead of ifelse since ifelse force evaluation of the RHS #78

Merged
merged 1 commit into from
Aug 6, 2024
Merged

use ternery instead of ifelse since ifelse force evaluation of the RHS #78

merged 1 commit into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. Use branches when choosing how to merge face attrs 

    While ifelse looked like a reasonable choice, it turns out that the
performance (allocations in particular) is improved by creating a
branch. We go from 2 allocations to 0 when merging faces, which very
much adds up over time.
    @KristofferC @tecosaur
    KristofferC authored and tecosaur committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9b9cf71 View commit details
    Browse the repository at this point in the history