Skip to content

Commit

Permalink
warn only
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth committed Mar 28, 2024
1 parent 8cc4cc1 commit 1172d6b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1485,11 +1485,10 @@ function run_extension_callbacks(pkgid::PkgId)
extids === nothing && return
for extid in extids
if in(extid.id, precompilation_stack)
@debug """
@warn """
Dependency cycle detected in extension precompilation: $(precompilation_stack_list()) > $(extid.id.name)
$(extid.id.name) will not be loaded here.
Loading $(extid.id.name) here will likely fail.
"""
continue
end
if extid.ntriggers > 0
# indicate pkgid is loaded
Expand Down
3 changes: 2 additions & 1 deletion test/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,8 @@ end
@testset "avoid circular precompilation deadlock through extensions" begin
testenv = joinpath(@__DIR__, "extensions", "circular")
s = read(`$(Base.julia_cmd()) --startup-file=no --project=$testenv -e 'using A'`, String)
@test !occursin("Error during loading of extension", s)
@test occursin("Dependency cycle detected in extension precompilation", s)
@test occursin("Error during loading of extension", s) # TODO: avoid the error? https://github.com/JuliaLang/julia/pull/53112
end
finally
try
Expand Down

0 comments on commit 1172d6b

Please sign in to comment.