Skip to content

Commit

Permalink
Speed up copyto!(::HermOrSym, ::HermOrSym) (#54476)
Browse files Browse the repository at this point in the history
  • Loading branch information
@dkarrasch
dkarrasch authored May 16, 2024
1 parent d96973f commit 16d70b5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions stdlib/LinearAlgebra/src/symmetric.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ copy(A::Hermitian) = (Hermitian(parentof_applytri(copy, A), sym_uplo(A.uplo)))

function copyto!(dest::Symmetric, src::Symmetric)
if src.uplo == dest.uplo
copyto!(dest.data, src.data)
copytrito!(dest.data, src.data, src.uplo)
else
transpose!(dest.data, Base.unalias(dest.data, src.data))
end
Expand All @@ -356,7 +356,7 @@ end

function copyto!(dest::Hermitian, src::Hermitian)
if src.uplo == dest.uplo
copyto!(dest.data, src.data)
copytrito!(dest.data, src.data, src.uplo)
else
adjoint!(dest.data, Base.unalias(dest.data, src.data))
end
Expand Down

5 comments on commit 16d70b5

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@Zentrik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collection benchmark regressions are noise, regression shows up in comparison to results since yesterday even though there don't seem to be any relevant changes https://tealquaternion.camdvr.org/compare.html?start=9ea4536f1a3693fd016133a7a9a611b08802f66b&end=16d70b53f3e2493310b1bca61b3dcc861284a248&stat=min-wall-time.

Please sign in to comment.