Don't recurse lowering symbol renaming through Expr(:toplevel)

Fixes #53729.
JuliaLang · Mar 13, 2024 · 1d73b36 · 1d73b36
1 parent 929dc76
commit 1d73b36
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/julia-syntax.scm b/src/julia-syntax.scm
@@ -5131,7 +5131,7 @@ f(x) = yt(x)
             ((nospecialize-meta? e)
              ;; convert nospecialize vars to slot numbers
              `(meta ,(cadr e) ,@(map renumber-stuff (cddr e))))
-            ((or (atom? e) (quoted? e) (eq? (car e) 'global))
+            ((or (atom? e) (quoted? e) (eq? (car e) 'global) (eq? (car e) 'toplevel))
              e)
             ((ssavalue? e)
              (let ((idx (get ssavalue-table (cadr e) #f)))

diff --git a/test/syntax.jl b/test/syntax.jl
@@ -3669,3 +3669,7 @@ let nnames = length(names(MacroHygieneGenerator; all=true))
     @test (MacroHygieneGenerator.@gen3) == Bool[false]
     @test length(names(MacroHygieneGenerator; all=true)) == nnames
 end
+
+# Issue #53729 - Lowering recursion into Expr(:toplevel)
+@test eval(Expr(:let, Expr(:block), Expr(:block, Expr(:toplevel, :(f53729(x) = x)), :(x=1)))) == 1
+@test f53729(2) == 2