Skip to content

Commit

Permalink
Precompile cache: always add worklist CIs (#47924)
Browse files Browse the repository at this point in the history
We cache only those external CodeInstances that link back to the
package being precompiled. Formerly we required a backedge;
this PRs adds any whose `specTypes` could only link back to the
package. This scoops up a few runtime-dispatched CodeInstances
and their callees.
  • Loading branch information
timholy authored Dec 20, 2022
1 parent 70c1e45 commit 1f0700a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/staticdata_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static int has_backedge_to_worklist(jl_method_instance_t *mi, htable_t *visited,
if (jl_is_method(mod))
mod = ((jl_method_t*)mod)->module;
assert(jl_is_module(mod));
if (mi->precompiled || !jl_object_in_image((jl_value_t*)mod)) {
if (mi->precompiled || !jl_object_in_image((jl_value_t*)mod) || type_in_worklist(mi->specTypes)) {
return 1;
}
if (!mi->backedges) {
Expand Down

0 comments on commit 1f0700a

Please sign in to comment.