Manually hoist conversion of end-of-line character to UInt8 (#16886)

In some confiurations LLVM doesn't seem to do this optimization Fix #16822
JuliaLang · Jun 13, 2016 · 2119ea6 · 2119ea6 · nanosoldier · Jun 14, 2016
1 parent a84f702
commit 2119ea6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/base/datafmt.jl b/base/datafmt.jl
@@ -18,12 +18,13 @@ const offs_chunk_size = 5000
 countlines(f::AbstractString, eol::Char='\n') = open(io->countlines(io,eol), f)::Int
 function countlines(io::IO, eol::Char='\n')
     isascii(eol) || throw(ArgumentError("only ASCII line terminators are supported"))
+    aeol = UInt8(eol)
     a = Array{UInt8}(8192)
     nl = 0
     while !eof(io)
         nb = readbytes!(io, a)
         @simd for i=1:nb
-            @inbounds nl += a[i] == UInt8(eol)
+            @inbounds nl += a[i] == aeol
         end
     end
     nl