print parentheses around dotted operators, fix #26517 (#26531)

JuliaLang · Mar 20, 2018 · 2723d74 · 2723d74 · nanosoldier · Mar 21, 2018
1 parent aa7b3f9
commit 2723d74
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/show.jl b/base/show.jl
@@ -972,7 +972,7 @@ end
 # show a normal (non-operator) function call, e.g. f(x, y) or A[z]
 function show_call(io::IO, head, func, func_args, indent)
     op, cl = expr_calls[head]
-    if (isa(func, Symbol) && func !== :(:)) ||
+    if (isa(func, Symbol) && func !== :(:) && !(head === :. && isoperator(func))) ||
             (isa(func, Expr) && (func.head == :. || func.head == :curly))
         show_unquoted(io, func, indent)
     else

diff --git a/test/show.jl b/test/show.jl
@@ -826,6 +826,9 @@ end
 @test repr(:(f.(X, Y))) == ":(f.(X, Y))"
 @test repr(:(f.(X))) == ":(f.(X))"
 @test repr(:(f.())) == ":(f.())"
+# broadcasted operators (#26517)
+@test_repr ":(y .= (+).(x, (*).(3, sin.(x))))"
+@test repr(:(y .= (+).(x, (*).(3, (sin).(x))))) == ":(y .= (+).(x, (*).(3, sin.(x))))"
 
 # pretty-printing of other `.` exprs
 test_repr("a.b")