Skip to content

Commit

Permalink
correct incomplete sentence (#47524)
Browse files Browse the repository at this point in the history
* correct incomplete sentence

* provide link for rata die
  • Loading branch information
udohjeremiah authored Dec 7, 2022
1 parent 3e9ca03 commit 5060aed
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions stdlib/Dates/docs/src/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ julia> Dates.monthabbr(t;locale="french")
```

Since the abbreviated versions of the days are not loaded, trying to use the
function `dayabbr` will error.
function `dayabbr` will throw an error.

```jldoctest tdate2
julia> Dates.dayabbr(t;locale="french")
Expand Down Expand Up @@ -640,8 +640,8 @@ by 10.
As Julia [`Date`](@ref) and [`DateTime`](@ref) values are represented according to the ISO 8601
standard, `0000-01-01T00:00:00` was chosen as base (or "rounding epoch") from which to begin the
count of days (and milliseconds) used in rounding calculations. (Note that this differs slightly
from Julia's internal representation of [`Date`](@ref) s using Rata Die notation; but since the
ISO 8601 standard is most visible to the end user, `0000-01-01T00:00:00` was chosen as the rounding
from Julia's internal representation of [`Date`](@ref) s using [Rata Die notation](https://en.wikipedia.org/wiki/Rata_Die);
but since the ISO 8601 standard is most visible to the end user, `0000-01-01T00:00:00` was chosen as the rounding
epoch instead of the `0000-12-31T00:00:00` used internally to minimize confusion.)

The only exception to the use of `0000-01-01T00:00:00` as the rounding epoch is when rounding
Expand Down

4 comments on commit 5060aed

@maleadt
Copy link
Member

@maleadt maleadt commented on 5060aed Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PkgEval test, using crun:

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your job failed. cc @maleadt

@maleadt
Copy link
Member

@maleadt maleadt commented on 5060aed Dec 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible issues were detected. A full report can be found here.

Please sign in to comment.