Skip to content

Commit

Permalink
fix references
Browse files Browse the repository at this point in the history
  • Loading branch information
LilithHafner committed Nov 17, 2023
1 parent 8056f88 commit 5656a89
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion doc/src/manual/style-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ This would provide custom showing of vectors with a specific new element type. W
this should be avoided. The trouble is that users will expect a well-known type like `Vector()`
to behave in a certain way, and overly customizing its behavior can make it harder to work with.

## Avoid type piracy
## [Avoid type piracy](@id avoid-type-piracy)

"Type piracy" refers to the practice of extending or redefining methods in Base
or other packages on types that you have not defined. In extreme cases, you can crash Julia
Expand Down
7 changes: 4 additions & 3 deletions doc/src/tutorials/creating-packages.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# **5.** Creating Packages
# [Creating Packages](@id creating-packages-tutorial)

## Generating files for a package

Expand Down Expand Up @@ -351,7 +351,8 @@ julia> write("test/runtests.jl",
## Compatibility on dependencies
Every dependency should in general have a compatibility constraint on it.
This is an important topic so there is a separate chapter about it: [Compatibility](@ref Compatibility).
This is an important topic so there is a chapter in the package docs about it:
[Compatibility](https://pkgdocs.julialang.org/v1/compatibility).
## Weak dependencies
Expand Down Expand Up @@ -475,7 +476,7 @@ function plot end

!!! note
If one considers `PlottingContourExt` as a completely separate package, it could be argued that defining `Plotting.plot(c::Contour.ContourCollection)` is
[type piracy](https://docs.julialang.org/en/v1/manual/style-guide/#Avoid-type-piracy) since `PlottingContourExt` _owns_ neither the function `Plotting.plot` nor the type `Contour.ContourCollection`.
[type piracy](@ref avoid-type-piracy) since `PlottingContourExt` _owns_ neither the function `Plotting.plot` nor the type `Contour.ContourCollection`.
However, for extensions, it is ok to assume that the extension owns the functions in its parent package.

In other situations, one may need to define new symbols in the extension (types, structs, functions, etc.) instead of reusing those from the parent package.
Expand Down

0 comments on commit 5656a89

Please sign in to comment.