Skip to content

Commit

Permalink
remove chmodding the pkgimages (#51885)
Browse files Browse the repository at this point in the history
This shouldn't be needed because `ldd` should do it itself.
  • Loading branch information
KristofferC authored Oct 31, 2023
1 parent 9075731 commit 5b34cdf
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2493,12 +2493,6 @@ function compilecache(pkg::PkgId, path::String, internal_stderr::IO = stderr, in

# inherit permission from the source file (and make them writable)
chmod(tmppath, filemode(path) & 0o777 | 0o200)
if cache_objects
# Ensure that the user can execute the `.so` we're generating
# Note that on windows, `filemode(path)` typically returns `0o666`, so this
# addition of the execute bit for the user is doubly needed.
chmod(tmppath_so, filemode(path) & 0o777 | 0o331)
end

# prune the directory with cache files
if pkg.uuid !== nothing
Expand Down

0 comments on commit 5b34cdf

Please sign in to comment.