with_env(key,val): temporarily set and restore an evironment value.

Use this to fix #4494 — older gits don't support merge --no-edit.
JuliaLang · Oct 12, 2013 · 7dfa093 · 7dfa093 · kmsquire · Oct 12, 2013
1 parent 7b437bb
commit 7dfa093
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/base/env.jl b/base/env.jl
@@ -141,6 +141,18 @@ function show(io::IO, ::EnvHash)
     end
 end
 
+# temporarily set and then restore an environment value
+function with_env(f::Function, key::String, val)
+    old = get(ENV,key,nothing)
+    val != nothing ? (ENV[key]=val) : _unsetenv(key)
+    try f()
+    finally
+        old != nothing ? (ENV[key]=old) : _unsetenv(key)
+    catch
+        rethrow()
+    end
+end
+
 ## misc environment-related functionality ##
 
 tty_cols() = parseint(Int32, get(ENV,"COLUMNS","80"), 10)

diff --git a/base/pkg/entry.jl b/base/pkg/entry.jl
@@ -184,7 +184,9 @@ function update(branch::String)
             Git.run(`checkout -q $branch`)
         end
         # TODO: handle merge conflicts
-        Git.run(`pull -q --no-edit`, out=DevNull)
+        with_env("GIT_MERGE_AUTOEDIT","no") do
+            Git.run(`pull -q`, out=DevNull)
+        end
     end
     avail = Read.available()
     # this has to happen before computing free/fixed