Skip to content

Commit

Permalink
Relax abstractq test (#48694)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkarrasch authored Feb 16, 2023
1 parent 8b85fbd commit 8068e44
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 2 additions & 5 deletions stdlib/LinearAlgebra/src/adjtrans.jl
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

using Base: @propagate_inbounds
import Base: length, size, axes, IndexStyle, getindex, setindex!, parent, vec, convert, similar

### basic definitions (types, aliases, constructors, abstractarray interface, sundry similar)

# note that Adjoint and Transpose must be able to wrap not only vectors and matrices
Expand All @@ -12,7 +9,7 @@ import Base: length, size, axes, IndexStyle, getindex, setindex!, parent, vec, c
Adjoint
Lazy wrapper type for an adjoint view of the underlying linear algebra object,
usually an `AbstractVector`/`AbstractMatrix`, but also some `Factorization`, for instance.
usually an `AbstractVector`/`AbstractMatrix`.
Usually, the `Adjoint` constructor should not be called directly, use [`adjoint`](@ref)
instead. To materialize the view use [`copy`](@ref).
Expand All @@ -39,7 +36,7 @@ end
Transpose
Lazy wrapper type for a transpose view of the underlying linear algebra object,
usually an `AbstractVector`/`AbstractMatrix`, but also some `Factorization`, for instance.
usually an `AbstractVector`/`AbstractMatrix`.
Usually, the `Transpose` constructor should not be called directly, use [`transpose`](@ref)
instead. To materialize the view use [`copy`](@ref).
Expand Down
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/test/abstractq.jl
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ n = 5
@test I*Q Q.Q*I rtol=2eps(real(T))
@test I*Q' I*Q.Q' rtol=2eps(real(T))
@test abs(det(Q)) 1
@test logabsdet(Q)[1] 0 atol=2eps(real(T))
@test logabsdet(Q)[1] 0 atol=2n*eps(real(T))
y = rand(T, n)
@test Q * y Q.Q * y Q' \ y ldiv!(Q', copy(y)) ldiv!(zero(y), Q', y)
@test Q'y Q.Q' * y Q \ y ldiv!(Q, copy(y)) ldiv!(zero(y), Q, y)
Expand Down

0 comments on commit 8068e44

Please sign in to comment.